Overhaul gradle inclusion/exclusion logic #620
Merged
+178
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
approved these changes
Jul 30, 2021
aws/sdk/gradle.properties
Outdated
| # | ||
|
|
||
| # base set of services that are generated unless other options are specified: | ||
| aws.services.tier1=+apigateway,+applicationautoscaling,+autoscaling,+autoscalingplans,+batch,+cloudformation,+cloudwatch,+cloudwatch,+cloudwatchlogs,+cognitoidentity,+cognitoidentityprovider,+cognitosync,+config,+dynamodb,+ebs,+ec2,+ecr,+ecs,+eks,+iam,+kinesis,+kms,+lambda,+medialive,+mediapackage,+polly,+qldb,+qldbsession,+rds,+rdsdata,+route53,+s3,+sagemaker,+sagemakera2iruntime,+sagemakeredge,+sagemakerfeaturestoreruntime,+secretsmanager,+sesv2,+snowball,+sns,+sqs,+ssm,+sts |
There was a problem hiding this comment.
Properties files allow you to break things over multiple lines if you want to make this more readable:
aws.services.tier1=\
+apigateway,\
+applicationautoscaling,\
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Our environment variable based gradle logic didn't work properly and was plagued by caching issues. I think this works and is the "right way" to do it. Two major changes:
input.propertythat compares equality of this value vs. the serialized value of the previous value allowing us to use the list of services as a compared property (after toStringing for serialization).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.