Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several waiter path matcher issues #3593

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

jdisanti
Copy link
Collaborator

While implementing waiters in another branch, I discovered and fixed a number of issues with the path matcher codegen logic. These issues were:

  • Generated code for nested flatten projections failed to compile due to the first projection producing a Vec<Vec<&T>> instead of Vec<&T>.
  • Path matchers that don't use input were taking input as an argument anyway, which results in an unnecessary clone of the input when used by the generated waiter logic.
  • The comparisons generated by RustWaiterMatcherGenerator would fail to compile whenever comparing a string against an enum.

This PR fixes all these issues.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner April 18, 2024 23:32
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 3f80a07 Apr 19, 2024
43 of 44 checks passed
@jdisanti jdisanti deleted the jdisanti-jmespath-issues branch April 19, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants