Re-export aws_smithy_types::date_time::Format in service client crates
#2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two more client re-exports that were not included in smithy-rs#2437: - `aws_smithy_http::byte_stream::Length` - `aws_smithy_types::date_time::Format`
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
Should we re-export these under |
This commit removes re-export of `aws_smithy_http::byte_stream::Length` for now as it is a feature-gated type, which requires further consideration.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
changed the title
aws_smithy_types::date_time::Format in service client crates
Yes, and as discussed off-line, we'll re-export them by prefixing. So |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Apr 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Velfi
approved these changes
Apr 6, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
pushed a commit
that referenced
this pull request
Apr 17, 2023
…tes (#2534) * Add more client crate re-exports This commit adds two more client re-exports that were not included in smithy-rs#2437: - `aws_smithy_http::byte_stream::Length` - `aws_smithy_types::date_time::Format` * Remove re-export of `aws_smithy_http::byte_stream::Length` This commit removes re-export of `aws_smithy_http::byte_stream::Length` for now as it is a feature-gated type, which requires further consideration. * CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]>
unexge
pushed a commit
that referenced
this pull request
Apr 24, 2023
…tes (#2534) * Add more client crate re-exports This commit adds two more client re-exports that were not included in smithy-rs#2437: - `aws_smithy_http::byte_stream::Length` - `aws_smithy_types::date_time::Format` * Remove re-export of `aws_smithy_http::byte_stream::Length` This commit removes re-export of `aws_smithy_http::byte_stream::Length` for now as it is a feature-gated type, which requires further consideration. * CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]>
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
…tes (#2534) * Add more client crate re-exports This commit adds two more client re-exports that were not included in smithy-rs#2437: - `aws_smithy_http::byte_stream::Length` - `aws_smithy_types::date_time::Format` * Remove re-export of `aws_smithy_http::byte_stream::Length` This commit removes re-export of `aws_smithy_http::byte_stream::Length` for now as it is a feature-gated type, which requires further consideration. * CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This small PR is a follow-up on #2437. We re-export
aws_smithy_types::date_time::Formatintoprimitives.rs(or intotypes.rsprior to the client crate re-organization).Description
Note if we run
rg aws_smithy_*inaws-doc-sdk-examples/rust_dev_preview, we see use statements onaws_smithy_types_convert::date_time::Erroraws_smithy_types_convert::date_time::DateTimeExtThese types are under consideration. They are feature-gated in
aws_smithy_types_convertand we probably do not want to turn on the cargo feature and re-export them by default across client crates.Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.