Support @sparse constrained map shapes and list shapes
#2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we've never supported them, neither directly constrained nor with constrained members, because of a lack of tests. Yet another data point to prioritize working on code-generating `constraints.smithy` (see #2101). The implementation is simple: we just need to call the symbol provider on the member symbols instead of on the target symbols so we get `Option<T>` list members / map values if applicable, and handle the wrapper when converting between unconstrained and constrained types with help from `match` and `Option<T>::map`.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
reviewed
Jan 17, 2023
| } | ||
| """, | ||
| "ConstrainedValueSymbol" to constrainedValueSymbol, | ||
| "Epilogue" to epilogueWritable, |
There was a problem hiding this comment.
Suggested change
| "Epilogue" to epilogueWritable, |
There was a problem hiding this comment.
This doesn't look to be used here in this block
There was a problem hiding this comment.
Fixed in b4ae60f.
crisidev
approved these changes
Jan 17, 2023
| } | ||
| """, | ||
| "ConstrainedValueSymbol" to constrainedValueSymbol, | ||
| "Epilogue" to epilogueWritable, |
There was a problem hiding this comment.
This doesn't look to be used here in this block
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Jan 17, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
deleted the
davidpz/support-sparse-constrained-maps-and-lists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we've never supported them, neither directly constrained nor
with constrained members, because of a lack of tests. Yet another data
point to prioritize working on code-generating
constraints.smithy(see#2101).
The implementation is simple: we just need to call the symbol provider
on the member symbols instead of on the target symbols so we get
Option<T>list members / map values if applicable, and handle thewrapper when converting between unconstrained and constrained types with
help from
matchandOption<T>::map.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.