AWS Endpoint Middleware #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit builds on the work of previous `Endpoint` work to incorporate AWS-specific endpoint abstractions.
rcoh
commented
Feb 9, 2021
| @@ -50,7 +50,7 @@ impl Credentials { | |||
| session_token, | |||
| expires_after: None, | |||
|
|
|||
| provider_name: STATIC_CREDENTIALS | |||
There was a problem hiding this comment.
formatting only. the CI format gate isn't set up for the aws runtime yet.
rcoh
commented
Feb 9, 2021
| @@ -3,13 +3,13 @@ | |||
| * SPDX-License-Identifier: Apache-2.0. | |||
aajtodd
approved these changes
Feb 10, 2021
| } | ||
| } | ||
|
|
||
| type AwsEndpointProvider = Arc<dyn ResolveAwsEndpoint>; |
There was a problem hiding this comment.
question
I see the term resolver used in some places and provider in others. Is this intentional?
There was a problem hiding this comment.
No, good catch. Halfway through I was looking at your doc and decided I liked Resolver better since it was a bit more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #109
Description of changes: Add AWS-specific endpoint support and middleware
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.