Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance methods in SDK taking Blob to take impl Into<Blob> instead #3879

Open
ysaito1001 opened this issue Oct 16, 2024 · 0 comments
Open

Enhance methods in SDK taking Blob to take impl Into<Blob> instead #3879

ysaito1001 opened this issue Oct 16, 2024 · 0 comments

Comments

@ysaito1001
Copy link
Contributor

This issue tracks a complementary task for #3877.

The previous PR introduced conversions between Vec<u8> and Blob, as well as from &[u8] to Blob. However, these changes do not immediately improve the ergonomics of the following method call (example from kms):

src/types/_recipient_info.rs:    pub fn set_attestation_document(mut self, input: ::std::option::Option<::aws_smithy_types::Blob>) -> Self {

To enhance the ergonomics of call sites, this codegen update modifies the method signature to accept Option<impl Into<Blob>>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant