-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade MSRV to 1.78.0 #3800
Upgrade MSRV to 1.78.0 #3800
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Aren't we affected by https://blog.rust-lang.org/2024/05/06/check-cfg.html when using the |
The provided link refers to Rust 1.80? Since this PR upgrades to Rust 1.78, we're not there yet (if I understand your question correctly)? If you mean "will we eventually be affected", then the answer is possibly. |
Motivation and Context
Upgrades MSRV to 1.78.0 since the latest Rust at the time of writing is 1.80.1 (we try keeping two releases behind).
Description
In Rust 1.78.0,
clippy
enforces stricter checks in two areas:dead_code
It seems to be able to uncover more unused code patterns, especially when different combinations of cargo features are enabled
empty_docs
Prior to 1.78.0, the codegen used to render the following empty docs
///
, regardless whether the codegen is for the server or for the client. This is now flagged asempty_docs
byclippy
:Other than bumping MSRV to 1.78.0, the remaining code changes address issues related to the fixes mentioned above.
EDIT:
cargo-semver-checks
required an upgrade due to incompatibility issues following the MSRV upgrade (example error). Specifically, after updating the MSRV to 1.78.0, the rustdoc version was upgraded to v28. However, the version ofcargo-semver-checks
we were using (0.24.1) only supported rustdoc up to v27.To resolve this, we have updated
cargo-semver-checks
to the first version that supports rustdoc v28.Testing
Existing tests in CI
Checklist
.changelog
directory, specifying "client," "server," or both in theapplies_to
key..changelog
directory, specifying "aws-sdk-rust" in theapplies_to
key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.