Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Only enforce content length for GET requests #3657

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented May 22, 2024

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@ysaito1001
Copy link
Contributor

Thanks Russell. We just need to change the target branch to main for this PR, instead of the release branch. We discovered a couple of weeks ago that directly bumping a runtime crate in the release branch without cutting a release confused runtime-versioner audit

runtime versioner refers to the latest release in smithy-rs when detecting baseline crates versions and compares those in the current active branch. If a runtime crate version gets bumped "secretly" in the release branch without a new release tag and subsequently published to crates.io, then the tool gets confused and complains that the crate version is ahead of the latest release tag but somehow that version is already available on crates.io.

@Velfi Velfi marked this pull request as ready for review May 22, 2024 15:56
@Velfi Velfi requested a review from a team as a code owner May 22, 2024 15:56
@Velfi Velfi changed the base branch from smithy-rs-release-1.x.y to main May 22, 2024 15:56
@Velfi Velfi enabled auto-merge May 22, 2024 16:01
@Velfi Velfi changed the title WIP: fix content length enforcement, needs tests Fix: Only enforce content length for GET requests May 22, 2024
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue May 22, 2024
@ysaito1001 ysaito1001 removed this pull request from the merge queue due to a manual request May 22, 2024
@ysaito1001 ysaito1001 requested a review from a team as a code owner May 22, 2024 17:11
@ysaito1001 ysaito1001 enabled auto-merge May 22, 2024 17:12
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@ysaito1001 ysaito1001 added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit db89652 May 22, 2024
44 checks passed
@ysaito1001 ysaito1001 deleted the fix-content-length branch May 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants