Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Metadata config bag type into a stable crate #3325

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Dec 15, 2023

This issue addresses a semver compatibility problem similar to the one described in #3318, except for the aws_smithy_http::operation::Metadata type.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will approve once CHANGELOG.next.toml has been updated.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It this kind of chicken-egg problem in terms of cargo semver-checks? We need move Metadata to a stable crate so we can eventually bump a minior version for aws-smithy-http from 0.60.1 to 0.61.0. But to cargo semver-checks, this is a breaking change as a pub item has been moved, requiring us to have 0.61.0 for aws-smithy-http with this change. But I suppose we can override what the tool says for this particular instance and claim that this is necessary for the grand scheme of things.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit e3f0de4 Jan 12, 2024
40 of 41 checks passed
@jdisanti jdisanti deleted the jdisanti-semver-metadata branch January 12, 2024 19:36
rcoh pushed a commit that referenced this pull request Jan 12, 2024
This issue addresses a semver compatibility problem similar to the one
described in #3318, except for the
`aws_smithy_http::operation::Metadata` type.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants