-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Metadata
config bag type into a stable crate
#3325
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will approve once CHANGELOG.next.toml
has been updated.
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It this kind of chicken-egg problem in terms of cargo semver-checks
? We need move Metadata
to a stable crate so we can eventually bump a minior version for aws-smithy-http
from 0.60.1
to 0.61.0
. But to cargo semver-checks
, this is a breaking change as a pub item has been moved, requiring us to have 0.61.0
for aws-smithy-http
with this change. But I suppose we can override what the tool says for this particular instance and claim that this is necessary for the grand scheme of things.
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
This issue addresses a semver compatibility problem similar to the one described in #3318, except for the `aws_smithy_http::operation::Metadata` type. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
This issue addresses a semver compatibility problem similar to the one described in #3318, except for the
aws_smithy_http::operation::Metadata
type.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.