Fix config::Builder::set_credentials_provider to override what's previsouly set
#3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/CredentialProviders.kt Co-authored-by: John DiSanti <[email protected]>
…/CredentialProviders.kt Co-authored-by: John DiSanti <[email protected]>
This commit addresses #3276 (comment)
This commit addresses #3276 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes awslabs/aws-sdk-rust#973
Description
Prior to the PR, if a customer explicitly passed a credentials provider to a client's config
Builder::set_credentials_provider, what's passed did not override a credentials provider previously set (actual use case).While in general, we recommend customers single-source a credentials provider through aws_config::ConfigLoader::credentials_provider, we should eliminate the said footgun in case they directly pass a credentials provider to a client's config
Builder.The PR reverts test signature updates in #3156 (in hindsight, having to update test signatures in that PR was a sign of regression).
Testing
Added a Kotlin test to
CredentialProviderConfigTest.ktto verify the fixChecklist
CHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.