Assorted cleanups of stable runtime crates #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
stable-crate-cleanups
branch
from
3c52d0f
to
62d5b9f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
stable-crate-cleanups
branch
from
d71f5bf
to
b4ebfee
Compare
jdisanti
approved these changes
Nov 16, 2023
Comment on lines
44
to
46
| if (it.name == "aws-sigv4") { | ||
| print(contents) | ||
| } |
There was a problem hiding this comment.
Looks like a debug print? Did you intend to keep this?
| // Invalid table definition on line 54: [target.'cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))'.dev-dependencies]] | ||
| logger.info("failed to read ${it.name} as TOML: $e") | ||
| Toml() | ||
| // sigv4 doesn't parse but it's stable now, hax hax hax |
| stable: bool, | ||
| } | ||
|
|
||
| pub(crate) struct StableCratesExposeStableCrates { |
There was a problem hiding this comment.
Neat! Check external types inception
|
No will remove
…On Wed, Nov 15, 2023, 10:05 PM John DiSanti ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In buildSrc/src/test/kotlin/CrateSetTest.kt
<#3205 (comment)>
:
> + if (it.name == "aws-sigv4") {
+ print(contents)
+ }
Looks like a debug print? Did you intend to keep this?
------------------------------
In buildSrc/src/test/kotlin/CrateSetTest.kt
<#3205 (comment)>
:
> } catch (e: java.lang.IllegalStateException) {
- // Currently, `aws-sigv4` cannot be read as a `TOML` because of the following error:
- // Invalid table definition on line 54: [target.'cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))'.dev-dependencies]]
- logger.info("failed to read ${it.name} as TOML: $e")
- Toml()
+ // sigv4 doesn't parse but it's stable now, hax hax hax
😆
------------------------------
In tools/ci-build/sdk-lints/src/lint_cargo_toml.rs
<#3205 (comment)>
:
> @@ -224,3 +227,170 @@ fn fix_docs_rs(contents: &str) -> Result<String> {
)?;
Ok(new)
}
+
+#[derive(Deserialize)]
+struct SmithyRsMetadata {
+ #[serde(rename = "smithy-rs-release-tooling")]
+ smithy_rs_release_tooling: ToolingMetadata,
+}
+
+#[derive(Deserialize)]
+struct ToolingMetadata {
+ stable: bool,
+}
+
+pub(crate) struct StableCratesExposeStableCrates {
Neat! Check external types inception
—
Reply to this email directly, view it on GitHub
<#3205 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZ53252AJESWDLKUTKLYEV7JHAVCNFSM6AAAAAA7NCZMYCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZTGQYTGMRUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ysaito1001
approved these changes
Nov 16, 2023
rcoh
force-pushed
the
stable-crate-cleanups
branch
from
bda5699
to
37f4005
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Stable crates MUST only expose other stable crates.
Description
This:
Testing
CI run
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.