Delete aws_smithy_http::ResolveEndpoint and point usages to service-specific trait
#3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
changed the title
aws_smithy_http::ResolveEndpoint and point usages to service-specific trait
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-removal
branch
from
0985606 to
e11250d
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-removal
branch
from
e11250d to
016ea77
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-removal
branch
from
016ea77 to
76ff6de
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-removal
branch
from
76ff6de to
3ebc0ad
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Oct 18, 2023
...client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/ClientRustModule.kt
Show resolved
Hide resolved
...in/software/amazon/smithy/rust/codegen/client/smithy/endpoint/EndpointConfigCustomization.kt
Outdated
Show resolved
Hide resolved
...in/software/amazon/smithy/rust/codegen/client/smithy/endpoint/EndpointConfigCustomization.kt
Outdated
Show resolved
Hide resolved
Comment on lines
111
to
113
| /// provide a shared endpoint resolver, use [`Self::set_endpoint_resolver`]. | ||
| /// ## Examples | ||
| /// ```no_run |
There was a problem hiding this comment.
Suggested change
| /// provide a shared endpoint resolver, use [`Self::set_endpoint_resolver`]. | |
| /// ## Examples | |
| /// ```no_run | |
| /// provide a shared endpoint resolver, use [`Self::set_endpoint_resolver`]. | |
| /// | |
| /// ## Examples | |
| /// Create an endpoint resolver that gives a different endpoint per | |
| /// stage (e.g., staging vs. production): | |
| /// ```no_run |
...re/amazon/smithy/rust/codegen/client/smithy/endpoint/generators/EndpointResolverGenerator.kt
Outdated
Show resolved
Hide resolved
...re/amazon/smithy/rust/codegen/client/smithy/endpoint/generators/EndpointResolverGenerator.kt
Outdated
Show resolved
Hide resolved
...re/amazon/smithy/rust/codegen/client/smithy/endpoint/generators/EndpointResolverGenerator.kt
Show resolved
Hide resolved
| /// endpoint params for the service. It then delegates endpoint resolution | ||
| /// to an underlying resolver that is aware of the concrete type. | ||
| #[derive(Clone, Debug)] | ||
| pub struct DefaultEndpointResolver<Params> { |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Oct 18, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
added a commit
that referenced
this pull request
Oct 19, 2023
…-specific trait (#3078) ## Motivation and Context - Fixes #3043 As a follow up to #3072 this removes the old endpoint resolver interfaces in favor of creating a per-service resolver trait. This trait defines a `into_shared_resolver()` method which converts the local trait into a global resolver that can be used with the orchestrator. ## Description <!--- Describe your changes in detail --> ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As a follow up to #3072 this removes the old endpoint resolver interfaces in favor of creating a per-service resolver trait.
This trait defines a
into_shared_resolver()method which converts the local trait into a global resolver that can be used with the orchestrator.Description
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.