New-type all the orchestrator futures #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Oct 11, 2023
Comment on lines
+39
to
+48
| pub fn new_boxed( | ||
| future: std::pin::Pin< | ||
| Box<dyn std::future::Future<Output = Result<$output, $err>> + Send>, | ||
| >, | ||
| ) -> Self { | ||
| Self { | ||
| inner: aws_smithy_async::future::now_or_later::NowOrLater::new(future), | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
can we use the downcast trick here?
There was a problem hiding this comment.
I don't think it would work so well here since the Pin<Box<...>> type would need to be just right, and the chances of that are slim.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-newtype-futures
branch
from
5f6baa6 to
1ec04d1
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
Futuretype-alias that was pointing toNowOrLaterwith a new-type for each trait that returns a future.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.