Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining middleware code #3038

Merged
merged 16 commits into from
Oct 9, 2023
Merged

Remove remaining middleware code #3038

merged 16 commits into from
Oct 9, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Oct 6, 2023

This PR removes the remaining rust-runtime code to support middleware, deprecates empty crates, and removes the remaining codegen references to any of that code. In the interest of keeping code review easier, a separate PR will finish addressing the remaining TODO(enableNewSmithyRuntime) comments.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti added the breaking-change This will require a breaking change label Oct 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

@jdisanti jdisanti marked this pull request as ready for review October 7, 2023 00:26
@jdisanti jdisanti requested review from a team as code owners October 7, 2023 00:26
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Copy link
Contributor

@Velfi Velfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jdisanti jdisanti added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 08196ec Oct 9, 2023
40 of 41 checks passed
@jdisanti jdisanti deleted the jdisanti-cleanup-middleware branch October 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants