Remove futures_core::stream::Stream from aws-smithy-async
#2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit responses to #2978 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
reviewed
Sep 15, 2023
This commit addresses #2978 (comment)
This commit addresses #2978 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
requested changes
Sep 26, 2023
This commit addresses #2978 (comment)
This commit addresses #2978 (comment)
This commit addresses #2978 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Sep 27, 2023
ysaito1001
deleted the
ysaito/remove-futures-stream-from-smithy-async
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
## Motivation and Context Fixes [canary failures](https://github.com/awslabs/aws-sdk-rust/actions/runs/6345490441/job/17237658244) by updating the-last-release-before-breaking-change module in `canary-lambda`. ## Description [A previous PR](#2978) removing the `Steram` trait from public API had a breaking change, requiring canary to update its code. The latest release at the time while the PR was worked on was `release-2023-08-23` so we created a new module with that date and moved the previously working canary's code prior to the breaking change to it. The `latest` module then contained canary's code after the breaking change. However, before that PR was merged to main, we made several releases in `aws-sdk-rust`, making `release-2023-08-23` no longer the latest release before the breaking change; a new one is `release_2023_09_25`. Hence this PR. ## Testing Manually executed ``` ➜ canary-runner git:(ysaito/fix-canary-module-dates) cargo run -- build-bundle --canary-path ../canary-lambda --sdk-release-tag release-2023-09-25 --musl --manifest-only ➜ canary-runner git:(ysaito/fix-canary-module-dates) cd ../canary-lambda ➜ canary-lambda git:(ysaito/fix-canary-module-dates) cargo check ``` (also tested for `--sdk-release-tag` with `release-2023-09-22` and `release-2023-09-20`) ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Removes
futures_core::stream::Streamfrom theaws-smithy-asynccrate.Description
This PR is part of our ongoing effort, #2413. We remove the
futures_core::stream::Streamtrait from the public API in theaws-smithy-asynccrate. While doing so, we compensateFnStreamby providing the explicit.nextand.collectmethods to let the previously working code continue working.TryFlatMapby making it return a new-type wrapperPaginationStreamto hideFnStreamfrom those who use paginators.With this change, the latest canary no longer uses
tokio_stream::StreamExt, since the paginator does not work in terms of theStreamtrait. Furthermore,aws-sdk-rusthas been more than 3 releases since release-2023-01-26, so the modulerelease-2023-01-26has been removed fromcanary-lambda.Testing
No new tests added, but made sure the existing tests keep working with the change.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.