Update aws_smithy_types::date_time::Format::HttpDate to omit fractional seconds
#2831
Labels
Comments
|
This was marked as a good first issue? This strikes me as potentially very complicated, in terms of its implications. |
|
I think the implications are outside of our control here. We need to update the date time serializer to remove the fractional part because services are currently rejecting requests when they have them. If more subtle behavior is required, then we need an update to the Smithy spec. The implementation itself seems straightforward enough since it's just deleting https://github.com/awslabs/smithy-rs/blob/main/rust-runtime/aws-smithy-types/src/date_time/format.rs#L482 I think? |
|
Ok, makes sense. |
rschmitt
added a commit
to rschmitt/smithy-rs
that referenced
this issue
Sep 18, 2023
rschmitt
added a commit
to rschmitt/smithy-rs
that referenced
this issue
Sep 18, 2023
1 task
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 21, 2023
## Motivation and Context Closes #2831. ## Description Fractional seconds will still be accepted during parsing, but not emitted during serialization. ## Testing ``` ./gradlew codegen-core:check codegen-client:check codegen-server:check codegen-client-test:check codegen-server-test:check ``` ## Checklist - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: Russell Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per smithy-lang/smithy#1847, we need to update
aws_smithy_types::date_time::Format::HttpDateto omit fractional seconds.The text was updated successfully, but these errors were encountered: