Simplify event stream message signer configuration #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
jdisanti-sra-eventstreams
branch
from
6c7eb17 to
9ba10cf
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-sra-eventstreams
branch
from
9ba10cf to
5103ddc
Compare
This PR creates a `DeferredSigner` implementation that allows for the event stream message signer to be wired up by the signing implementation later in the request lifecycle rather than by adding an event stream signer method to the config. Refactoring this brings the middleware client implementation closer to how the orchestrator implementation will work, which unblocks the work required to make event streams work in the orchestrator.
jdisanti
force-pushed
the
jdisanti-sra-eventstreams
branch
from
5103ddc to
d76c982
Compare
jdisanti
added
breaking-change
|
Never mind. This will break anyone stuck on an old code generator that is using event streams. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
I made the changes semver compliant. They're still behavioral breaking for anyone implementing a custom event stream signer, but I think that should be OK since the fix is easy, and the chances anyone is doing that are low. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
May 8, 2023
82marbag
approved these changes
May 11, 2023
Velfi
approved these changes
May 11, 2023
jdisanti
added
ready-to-merge
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
added a commit
that referenced
this pull request
May 26, 2023
## Motivation and Context This PR gets event streams working in the client orchestrator implementation, and depends on #2671. The orchestrator's `TypeErasedBox` enforces a `Send + Sync` requirement on inputs and outputs. For the most part, this isn't an issue since almost all generated inputs/outputs are `Send + Sync`, but it turns out the `EventStreamSender` wasn't `Sync` due to an omission of the `Sync` bound. Thus, this PR is a breaking change, as it adds a `Sync` requirement for anyone who passes a stream to an event stream operation. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR creates a
DeferredSignerimplementation that allows for the event stream message signer to be wired up by the signing implementation later in the request lifecycle rather than by adding an event stream signer method to the config.Refactoring this brings the middleware client implementation closer to how the orchestrator implementation will work, which unblocks the work required to make event streams work in the orchestrator.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.