Add send_with method to fluent builders #2652
Conversation
- Add serde related attributes
| /// client.$fnName().set_fields(&deserialized_parameters).send().await | ||
| /// }; | ||
| /// ``` | ||
| pub fn set_fields(mut self, data: $inputBuilderType) -> Self { |
There was a problem hiding this comment.
Would it be possible to go in the other direction and have an input take a client to form a fluent builder? Something like:
SomeInput::builder()
.some_field("foo")
.with_client(client) // returns the fluent builder corresponding to the SomeInput operation
.send()
.awaitMy reasoning is that set_fields could be called after some fields are set, and it would overwrite those fields, which could be confusing. If the API is designed so that that's not possible, all the better.
There was a problem hiding this comment.
I think this is lot better. I'm not quite sure if you can do this though. Let me investigate.
There was a problem hiding this comment.
I implemented like this.
Example::builder().into_fluent_builder(client).send().await;Example:
impl AddPermissionInputBuilder {
#[cfg(aws_sdk_unstable)]
/// Creates a fluent builder from this builder.
pub fn into_fluent_builder(self, client: &crate::Client) -> AddPermissionFluentBuilder {
let fluent_builder = client.add_permission();
fluent_builder.inner = self;
fluent_builder
}
}There was a problem hiding this comment.
fn into_* is used when it takes up the ownership to create a value as another datatype so I think this name is good.
There was a problem hiding this comment.
Talking to the team a bit more about this, would making this into a send_with function be better? Something like:
SomeInput::builder()
.some_field("foo")
.send_with(&client)
.await
...software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientGenerator.kt
Outdated
Show resolved
Hide resolved
| implBlock(symbolProvider.symbolForBuilder(input)) { | ||
| rustTemplate( | ||
| """ | ||
| ##[#{AwsSdkUnstableAttribute}] |
There was a problem hiding this comment.
This function will be just generally useful, so I would say let's remove the unstable attribute from it. May as well keep the supporting machinery around for your other PRs though.
| /// client.$fnName().set_fields(&deserialized_parameters).send().await | ||
| /// }; | ||
| /// ``` | ||
| pub fn set_fields(mut self, data: $inputBuilderType) -> Self { |
There was a problem hiding this comment.
Talking to the team a bit more about this, would making this into a send_with function be better? Something like:
SomeInput::builder()
.some_field("foo")
.send_with(&client)
.await
…egen/client/smithy/generators/client/FluentClientGenerator.kt Co-authored-by: John DiSanti <[email protected]>
|
Everything is fixed! |
|
Kicked off PR bot so we can see a codegen diff: https://github.com/awslabs/smithy-rs/actions/runs/5259633320 |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
Actually, could you add an entry to the |
|
I updated the changelog. Does it work? |
thomas-k-cameron
changed the title
send_with method to fluent builderssend_with method to fluent builders and add serde support to SDK geenrated datatypes
thomas-k-cameron
changed the title
send_with method to fluent builders and add serde support to SDK geenrated datatypes
Motivation and Context
This is a child PR of #2615.
Description
send_withmethod to Fluent Builder.Prerequisite PRs
You can merge this first too reduce diffs.
Testing
NA
Checklist
NA
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.