Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PollError from server type parameters #2457

Merged
merged 9 commits into from
May 30, 2023
Merged

Remove PollError from server type parameters #2457

merged 9 commits into from
May 30, 2023

Conversation

hlbarber
Copy link
Contributor

Motivation and Context

#2444

Description

Remove PollError from the implementation and documentation.

@hlbarber hlbarber added server Rust server SDK needs-server-review refactoring Changes that do not affect our users, mostly focused on maintainability labels Mar 14, 2023
@hlbarber hlbarber changed the title Remove PollError Remove PollError from server type parameters Mar 14, 2023
@hlbarber hlbarber marked this pull request as ready for review March 14, 2023 19:04
@hlbarber hlbarber requested a review from a team as a code owner March 14, 2023 19:04
@hlbarber hlbarber marked this pull request as draft March 14, 2023 19:36
@hlbarber hlbarber marked this pull request as ready for review March 14, 2023 20:50
@hlbarber hlbarber mentioned this pull request Mar 15, 2023
Open
@hlbarber hlbarber requested a review from a team as a code owner March 15, 2023 11:07
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@smithy-lang smithy-lang deleted a comment from github-actions bot Mar 15, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Mar 15, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Mar 15, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Mar 15, 2023
@hlbarber hlbarber added the breaking-change This will require a breaking change label Apr 19, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@hlbarber hlbarber enabled auto-merge May 30, 2023 19:52
@hlbarber hlbarber added this pull request to the merge queue May 30, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Merged via the queue into main with commit 7347c58 May 30, 2023
@hlbarber hlbarber deleted the harryb/remove-poll-error branch May 30, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeMathWalker LukeMathWalker LukeMathWalker left review comments

@jjant jjant jjant left review comments

@82marbag 82marbag 82marbag approved these changes

@david-perez david-perez Awaiting requested review from david-perez david-perez was automatically assigned from awslabs/smithy-rs-server

@drganjoo drganjoo Awaiting requested review from drganjoo drganjoo was automatically assigned from awslabs/smithy-rs-server

Assignees
No one assigned
Labels
breaking-change This will require a breaking change refactoring Changes that do not affect our users, mostly focused on maintainability server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hlbarber @jjant @LukeMathWalker @82marbag @Velfi