Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webpki feature dependency #2170

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Remove webpki feature dependency #2170

merged 1 commit into from
Jan 5, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Jan 5, 2023

Motivation and Context

awslabs/aws-sdk-rust#706

Description

  • remove webpki feature
  • add additional feature to pull in webpki for the doctest

Testing

  • CI

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested a review from a team as a code owner January 5, 2023 11:06
@rcoh rcoh force-pushed the remove-webpki-feature branch from 7285bd9 to 2ef60f3 Compare January 5, 2023 11:10
@rcoh rcoh requested a review from a team as a code owner January 5, 2023 11:10
@rcoh rcoh requested review from crisidev and david-perez January 5, 2023 11:10
Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks Russell!

@rcoh rcoh enabled auto-merge (squash) January 5, 2023 11:15
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

A new generated diff is ready to view.

A new doc preview is ready to view.

@rcoh rcoh merged commit 4768926 into main Jan 5, 2023
@rcoh rcoh deleted the remove-webpki-feature branch January 5, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants