Smithy 1.26.2 upgrade / ensure that even empty lists are serialized #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
approved these changes
Nov 9, 2022
| // Calling this drops self | ||
| // https://github.com/awslabs/smithy/commit/715b1d94ab14764ad43496b016b0c2e85bcf1d1f | ||
| // If the list was empty, just serialize the parameter name | ||
| if self.next_index == 1 { |
There was a problem hiding this comment.
Not required since this is covered by protocol test, but it would be nice to have a Rust unit test for this.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
changed the title
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
changed the title
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
@jdisanti, let me know your thoughts on this approach. The spec was altered to state that empty lists should be serialized—I decided to handle this at the runtime-level, but I'm open to other suggestions.
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.