-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update with flexible zeroize version #1817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any Rustsec advisories on the zeroize
crate, and the aws-config
crate is currently using "1"
, so I think this change should be fine as long as CI passes.
If you want to be credited in the changelog with the next release, then be sure to add an |
It looks like the following message from the PR template's description was omitted when creating the PR:
Unfortunately, I can't merge this until it is added back in. But otherwise, it all looks good! |
Motivation and ContextUpdating the zeroize version in Cargo.toml in aws-types. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. |
Thank you for the contribution! I'll work on getting this merged. |
Motivation and Context
Updating the zeroize version in Cargo.toml in aws-types.
Specifying zeroize 1.4.1 only allows 1.4.1 and up. Many crates in production use 1.4 and less. Downgrading to 1.0.0 provides flexible versioning without sacrificing functionality.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.