Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with flexible zeroize version #1817

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Conversation

ethyi
Copy link
Contributor

@ethyi ethyi commented Oct 6, 2022

Motivation and Context

Updating the zeroize version in Cargo.toml in aws-types.
Specifying zeroize 1.4.1 only allows 1.4.1 and up. Many crates in production use 1.4 and less. Downgrading to 1.0.0 provides flexible versioning without sacrificing functionality.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ethyi ethyi requested a review from a team as a code owner October 6, 2022 04:34
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any Rustsec advisories on the zeroize crate, and the aws-config crate is currently using "1", so I think this change should be fine as long as CI passes.

@jdisanti
Copy link
Collaborator

jdisanti commented Oct 6, 2022

If you want to be credited in the changelog with the next release, then be sure to add an [[aws-sdk-rust]] entry to CHANGELOG.next.toml.

@ethyi ethyi requested a review from a team as a code owner October 10, 2022 19:23
@jdisanti
Copy link
Collaborator

It looks like the following message from the PR template's description was omitted when creating the PR:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Unfortunately, I can't merge this until it is added back in. But otherwise, it all looks good!

@ethyi
Copy link
Contributor Author

ethyi commented Oct 11, 2022

Motivation and Context

Updating the zeroize version in Cargo.toml in aws-types.
Specifying zeroize 1.4.1 only allows 1.4.1 and up. Many crates in production use 1.4 and less. Downgrading to 1.0.0 provides flexible versioning without sacrificing functionality.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ethyi ethyi requested a review from jdisanti October 11, 2022 03:49
@jdisanti
Copy link
Collaborator

Thank you for the contribution! I'll work on getting this merged.

@jdisanti jdisanti enabled auto-merge (squash) October 11, 2022 16:50
@jdisanti jdisanti merged commit 057fe97 into smithy-lang:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants