Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 7 #1411

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Upgrade to Gradle 7 #1411

merged 2 commits into from
Jun 23, 2022

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented May 25, 2022

Motivation and Context

  • By upgrading to Gradle 7, we enable developers to use smithy-rs with new JDKs.
  • Fixes gradle 7? #1167

Description

  • remove a small number of deprecated gradle features
  • run ./gradlew wrapper --version 7.4.2

Testing

  • ran a build

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners May 25, 2022 13:47
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec -0.15% 35886.38 35940.17
Total requests -0.14% 3231719 3236316
Total errors NaN% 0 0
Total successes -0.14% 3231719 3236316
Average latency ms 2.17% 0.94 0.92
Minimum latency ms -33.33% 0.02 0.03
Maximum latency ms 36.37% 22.72 16.66
Stdev latency ms 14.75% 0.7 0.61
Transfer Mb -0.14% 335.94 336.42
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Rust Wrk benchmark report:

Duration: 90 sec, Connections: 32, Threads: 2

Measurement Deviation Current Old
Requests/sec 17.29% 82779.94 70577.74
Total requests 17.26% 7455039 6357568
Total errors NaN% 0 0
Total successes 17.26% 7455039 6357568
Average latency ms 100.00% 1.08 0.54
Minimum latency ms 0.00% 0.02 0.02
Maximum latency ms 17.05% 23.96 20.47
Stdev latency ms 188.24% 1.96 0.68
Transfer Mb 17.26% 774.96 660.87
Connect errors NaN% 0 0
Read errors NaN% 0 0
Write errors NaN% 0 0
Status errors (not 2xx/3xx) NaN% 0 0
Timeout errors NaN% 0 0

Copy link
Contributor

@crisidev crisidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@rcoh rcoh merged commit edb1394 into main Jun 23, 2022
@rcoh rcoh deleted the gradle-7 branch June 23, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradle 7?
3 participants