-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move re-exports into types
and re-export AggregatedBytes
#1085
Conversation
Opening this PR as a draft to gather feedback. This change will also require updating all the examples, which I want to hold off on until consolidation is complete. Open questions:
|
A new generated diff is ready to view. |
A new doc preview is ready to view. |
I like setting and sticking to conventions so putting it in types makes sense to me unless that somehow makes codegen more difficult.
On first thought, I think it shouldn't be re-exported. However, I'm worried about SDKs that add and then remove a bytestream based api. Is that something we need to consider or will that never happen? |
generally APIs can't be removed |
Will proceed with:
Will also make |
A new doc preview is ready to view. |
A new generated diff is ready to view. |
A new generated diff is ready to view. |
A new doc preview is ready to view. |
A new doc preview is ready to view. |
A new generated diff is ready to view. |
Examples fixed in awsdocs/aws-doc-sdk-examples#2776 |
A new doc preview is ready to view. |
A new generated diff is ready to view. |
A new doc preview is ready to view. |
A new generated diff is ready to view. |
Motivation and Context
This implements #944.
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.