Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing IO primitives for binary streaming #130

Closed
kggilmer opened this issue Mar 4, 2021 · 0 comments · Fixed by #264
Closed

Implement missing IO primitives for binary streaming #130

kggilmer opened this issue Mar 4, 2021 · 0 comments · Fixed by #264
Assignees
@aajtodd
Labels
feature-request A feature should be added or improved.
Milestone
M1

Comments

@kggilmer
Copy link
Contributor

kggilmer commented Mar 4, 2021 •
edited
Loading

  • Implement a FileSource such that a user can specify a file as a Source (will be useful for s3).
    • add to companion obj for ByteStream
    • make sure you consider rewinding capabilities for signing. See here
  • Implement an analogous Sink interface.
    • add extension ByteStream.toFile(path) and JVM extension ByteStream.toFile(File), etc.

See also the streaming design docs

internal id: 176599246
@kggilmer kggilmer added feature-request A feature should be added or improved. jr1614819667645 labels Mar 4, 2021
@aajtodd aajtodd removed the kotlin label Mar 4, 2021
@aajtodd aajtodd self-assigned this Mar 22, 2021
@aajtodd aajtodd added this to the M1 milestone Mar 22, 2021
@aajtodd aajtodd mentioned this issue Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aajtodd aajtodd

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
M1
Development

Successfully merging a pull request may close this issue.

feat(io): implement missing IO runtime primitives smithy-lang/smithy-kotlin
2 participants
@aajtodd @kggilmer