-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate energyLabel #1309
Conversation
src/components/energyLabel/index.tsx
Outdated
<Flex css={styles.root}> | ||
<Box css={styles.triangle} /> | ||
<Flex css={styles.textWrapper}> | ||
<Text css={styles.text}>{String(efficiency)}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use toString
instead to get errors in case of unexpected edge cases
…ruth for variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup
🎉 This PR is included in version 23.21.0-chakra-v3-dad7c706a879d6e3de9f03b392e072075b82c1be.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.21.0-chakra-v3-d535594acd3eb5da4c1e1e27e0b6544155da5cbf.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.21.0-chakra-v3-dc62598856183b8aba8d5e97dec1bceab7bf2b4a.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.24.0-chakra-v3-9352d0d9cc2473087f189a3a7a0a7c7e4ef327f4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.24.0-chakra-v3-718fa541db16562355948131d44da3d60cbaacd8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.24.0-chakra-v3-22446ebc77f39915b0f1e8b77ae7dbafd4f169c4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.26.0-chakra-v3-54a88396a7cc36e25644dfa15de82ddffb13a8fe.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
References FED-334
Motivation and context
Migrate component and it's recipe to V3.
This component was an ideal example of using slot recipe for both styling and defining it's props using recipe.
How to test
Locally in Storybook or branch deployment.