Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map.on(click) #148

Closed
netforce opened this issue Oct 17, 2017 · 7 comments
Closed

map.on(click) #148

netforce opened this issue Oct 17, 2017 · 7 comments

Comments

@netforce
Copy link

Following #92, and reading #138 and #129 i got myself a working version with draggable markers, updating location variables and almost completely as i want, but..

I'd still like to have the ability to add a marker onto the same map without using the searchplugin..
When i implement map.on('click') the bug of a marker being placed when clicking inside the searchbar re-appears.

I guess the map.on('click') even bypasses the disableHandlers and restoreHandlers wich fixed #138 ?
As i'v got this far in getting this to work i'd be ashamed for not getting this to work.

For my code see https://codepen.io/netforcenl/pen/xXQMrb or https://jsfiddle.net/netforcenl/0a4b3ufg/11/
Now i'm creating the jsfiddle from my original code i'm noticing that when i click the "close search results" x, i also lose my result (marker), and the searchbar does not close when selecting one result..

I'm seriously overlooking something it seems and any help is appreciated.

unpkg [email protected]
unpkg [email protected]

@hartman
Copy link

hartman commented Mar 16, 2018

I have this problem too. Quite annoying. Anyone figured out a solution ?

@dgana
Copy link

dgana commented Jun 25, 2018

Any quick solution for this issue?

@AceCat
Copy link

AceCat commented Jul 30, 2018

Wanted to check in and see if anyone had found a solution for this issue, it's driving me crazy.

@smeijer smeijer added this to the v3.1.0 milestone Apr 15, 2020
@ppulwey
Copy link

ppulwey commented Jan 6, 2021

This is still the case. Any update on this?

@smeijer
Copy link
Owner

smeijer commented Jan 7, 2021

Is there an updated reproduction available?

@smeijer
Copy link
Owner

smeijer commented Jan 7, 2021

I'm unable to reproduce this. Please let me know if you're able to create a reproduction based on this pen, so we can reopen and fix if I'm missing something.

https://codepen.io/smeijer/pen/YzGveWN?editors=0010

@smeijer smeijer closed this as completed Jan 7, 2021
@ppulwey
Copy link

ppulwey commented Jan 7, 2021

I'm using Vue2Leaflet with this wrapper for your package: https://www.npmjs.com/package/vue2-leaflet-geosearch
The npm version is outdated. I've installed latest version from Git-Repo.
It's working fine now! Thanks for your effort! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants