Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upper modifier and strftime usage in date_format if PHP > 8.1 #788

Conversation

cmelius
Copy link

@cmelius cmelius commented Aug 25, 2022

This fixes:
"|upper" and
"|date_format" (see #750 )
on PHP8.1

function php8strftime should probably be moved to some function.strftime.php to use with other occurrences of strftime?

@wisskid
Copy link
Contributor

wisskid commented Sep 9, 2022

@cmelius yes, the strftime-fix is too specific. strftime is also used in libs/plugins/function.html_select_date.php. See #672.
The upper changes seem fine. Do you want to update your PR? Or shall I copy your changes for the upper modifier?

@wisskid wisskid added the waiting Waiting for answer label Sep 9, 2022
@cmelius
Copy link
Author

cmelius commented Sep 9, 2022

You're welcome to copy. I am on vacation for the next two weeks so please go ahead.

Cheers

@wisskid
Copy link
Contributor

wisskid commented Sep 10, 2022

will do, closing this.

@wisskid wisskid closed this Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for answer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants