Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output buffer not cleaned on Throwable error #514

Closed
ErwinSteffens opened this issue Nov 23, 2018 · 1 comment · Fixed by #797
Closed

Output buffer not cleaned on Throwable error #514

ErwinSteffens opened this issue Nov 23, 2018 · 1 comment · Fixed by #797

Comments

@ErwinSteffens
Copy link

ErwinSteffens commented Nov 23, 2018 •
edited
Loading

We have an Error in one of our views like this:

Call to a member function getSettings() on null

This is thrown as an Error which extends Throwable. The error handling in Smarty only catches Exception for cleaning the output buffer:
https://github.com/smarty-php/smarty/blob/master/libs/sysplugins/smarty_internal_templatebase.php#L249

This messes up our error template output. I think you should catch Throwable on this point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean output buffer for Throwable instead of just Exception smarty-php/smarty
2 participants
@ErwinSteffens @wisskid