smarty uses iterator_count() on un-rewindable iterator, even if it isn;t needed

[quamis]

In Smarty_Internal_Runtime_Foreach

, the $total variable is computed even when not needed. This might be slow (I use iterators for very large resultsets) and it will also break one-way iterators (iterators that can only be iterated over once, not having a way of implementing the rewind() method).

I have attached a testcase. The rewind function should only get called once in this case
smarty bug testcase.zip

To fix this, please take a look at the attached patch:
Smarty_Internal_Runtime_Foreach.zip

Expected output:

Real output:

[uwetews]

This is now fixed in the master branch and will later be included in 3.1.33
Please note that the total property is required and will be computed also when you are using some other propteries like last and show

[quamis]

Any ideea when 3.1.33 will be released?

[uwetews]

Within the next 14 days quamis <[email protected]> schrieb am Do. 17. Mai 2018 um 15:36:

…

Any ideea when 3.1.33 will be released? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#443 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMDr24bd3IOl3ytxfebph_Jdmmfzye9ks5tzXz2gaJpZM4T9OFK> .