Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lens function consistency #283

Open
daedalus28 opened this issue Sep 10, 2019 · 0 comments
Open

Lens function consistency #283

daedalus28 opened this issue Sep 10, 2019 · 0 comments
Labels
Type: Breaking Change

Comments

@daedalus28
Copy link
Contributor

daedalus28 commented Sep 10, 2019 •
edited
Loading

It's a serious breaking change but we should probably rename flip to flips, since it returns a function that does the flipping. flip should actually flip.

on/off poses a challenge, but we can leave them as is and just add enable/enables + disable/disables or activate/activates + deactivate/deactivates (thanks to @michsa for that suggestion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Breaking Change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daedalus28