Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for new sensor types #33

Closed
smartSRA opened this issue Jun 19, 2023 · 6 comments
Closed

Provide support for new sensor types #33

smartSRA opened this issue Jun 19, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@smartSRA
Copy link
Collaborator

The new smartmicro sensor "a4" will shortly be available to the customers. This new sensor type should be supported by the driver. Also the DRVEGRD 152 has a new firmware which in return causes new interfaces and hence the driver should be adopted to allow the user support for the new user-interface.

@purple-mesh
Copy link

purple-mesh commented Jun 19, 2023

Also wondering if there is any plans to support UMRR-0C Type 42 and UMRR-12 Type 48 radars? Or any suggestions on how one might go about integrating it?

@smartSRA
Copy link
Collaborator Author

smartSRA commented Jun 20, 2023

Also wondering if there is any plans to support UMRR-0C Type 42 and UMRR-12 Type 48 radars? Or any suggestions on how one might go about integrating it?

Hey,

The sensor types you mentioned are for the traffic. This repository only supports automotive sensors. In theory you could follow this repository and instead of automotive sensors use the traffic sensors but for that you would require a smart access for the traffic. Smart access is the underlying library used by this repository.

@purple-mesh
Copy link

Thanks @smartSRA!

I do have the smart access library and can see how it gets used to initialise and parse the data.

Will probably give it a go at integrating it and see how that works out.

@smartSRA
Copy link
Collaborator Author

smartSRA commented Jun 21, 2023

Sounds great! do let me know how it goes.

@smartSRA smartSRA added the enhancement New feature or request label Jun 27, 2023
@purple-mesh
Copy link

purple-mesh commented Jul 4, 2023

Hey @smartSRA

Had some time today to tinker with this, happy to report that I have managed to get it working on my end without significant code changes.
Having everything already setup and organised in this repo made this really simple and straightforward.

The brief process I went through was:

  • Extract the traffic version of the smart access library, in this cased I was using SmartAccessTm_5_1_0
  • Update the ros2 node umrr_ros2_driver/src/smartmicro_radar_node.cpp file to support this additional radar type (in my case it is the umrr12), don't forget the header file too
  • Update void SmartmicroRadarNode::update_config_files_from_params() so that it sets "alive":true in the generated config file install/umrr_ros2_driver/share/umrr_ros2_driver/config/smart_access_config.json (automotive radar doesn't seem to require the alive protocol to be set to true?)
  • Update the umrr_ros2_driver/CMakeLists.txt file so that the corresponding files and libraries are sourced
  • Tweak the config files as per Readme.md
  • For testing I temporarily commented out all the existing supported radar types and just ran with the UMRR12 Type48 radar in simulation mode (enabled through Traffic Management Configurator).

Some minor differences in naming convention:

  • The automotive radars have headers such as Target.h
  • The traffic radars have headers such as TmTarget.h
  • This Tm prefix also extends across various method names, just need to watch out for those

@smartSRA
Copy link
Collaborator Author

smartSRA commented Jul 4, 2023

Hey @purple-mesh ,

Great!! That is exactly the way to go about it and glad to see you could figure out pretty quickly. Regarding the alive protocol yes, it is for the automotive sensors not supported and hence was set false which is not the case in traffic sensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants