Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of Point Cloud fields. #22

Closed
chilisam opened this issue Nov 9, 2022 · 1 comment
Closed

Wrong order of Point Cloud fields. #22

chilisam opened this issue Nov 9, 2022 · 1 comment

Comments

@chilisam
Copy link

chilisam commented Nov 9, 2022

In lines 96, 97 and 98 in

struct RadarPoint
{
float x{};
float y{};
float z{};
float radial_speed{};
float power{};
float RCS{};
float Noise{};

You have the following value order:

  1. power
  2. rcs
  3. noise

But when actually building the PCL message here:

modifier.push_back(
{range_2d * std::cos(azimuth_angle), range_2d * std::sin(azimuth_angle),
range * std::sin(elevation_angle), target->GetSpeedRadial(), target->GetRCS(),
target->GetTgtNoise(), target->GetPower()});
}

You have the order:

  1. rcs
  2. noise
  3. power

This applies also to all the other void SmartmicroRadarNode::targetlist_callback_*

@smartSRA
Copy link
Collaborator

smartSRA commented Nov 9, 2022

Thanks for pointing this out. I am going to update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants