Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0272] JavaScript Suite SDL Manager #123

Closed
theresalech opened this issue Mar 3, 2020 · 1 comment · Fixed by #125, #371 or #482
Closed

[SDL 0272] JavaScript Suite SDL Manager #123

theresalech opened this issue Mar 3, 2020 · 1 comment · Fixed by #125, #371 or #482
Labels
proposal Accepted SDL Evolution Proposal

Comments

@theresalech
Copy link
Collaborator

Proposal: JavaScript Suite SDL Manager

In a similar vein to this proposal, the goal is to introduce a manager layer to the JavaScript Suite, closely matching the Java Suite and iOS manager APIs. These manager classes are designed to abstract out complex flows and states for common tasks, such as file handling and displaying information to the screen.

Review: smartdevicelink/sdl_evolution#901

Steering Committee Decision:

The Steering Committee voted to accept this proposal with the revisions listed below:

  • (Item 2) Pass an AppConfig instance into the SDLManager constructor. The SDLManager start() method can perform the basic validation checks prior to starting the LifecycleManager to ensure the minimum properties of an AppConfig are provided, as well as a ManagerListener being defined.
  • (Item 3) Single-method listeners to be replaced with simple JavaScript-oriented callback functions.
  • (Item 7) Promises should be returned by manager methods which ultimately send one or more RPCs resulting in a single response. Developers then have the freedom to decide if/how they would like to handle the resolution or rejection of the RPC response. 
  • (Item 12) Remove getInternalInterface() in favor of utilizing the reference to the LifecycleManager

The proposal .md file was updated to reflect these revisions on 3/3/2020.

@crokita
Copy link
Contributor

crokita commented Feb 4, 2021

MenuManager needs to be implemented still

@crokita crokita reopened this Feb 4, 2021
@crokita crokita mentioned this issue Apr 14, 2021
@crokita crokita mentioned this issue Aug 27, 2021
4 tasks
@crokita crokita mentioned this issue Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
3 participants