Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove only app logic for device listener start #1879

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

joeygrover
Copy link
Member

@joeygrover joeygrover commented Dec 1, 2023

Fixes #1878

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Unit Tests

N/A

Core Tests

Test 1
  1. Connect BT with a device with an SDL app installed
  2. Allow the RS service to timeout for the connection
  3. Open the app again and select "Find new apps"
  4. Observe RS notification appears
Test 2
  1. Install another app with HelloSdl on device
  2. Connect over BT with IVI
  3. Redeploy HelloSdl
  4. Observe the router service is taken down and SDL connection is lost
  5. Wait a few seconds
  6. Observe the router service starts back up and IVI connects to it (Might have to use Find New Apps)
Test 3
  1. Ensure no BT device is connected
  2. Install HelloSdl
  3. Observe the device listener is not started

Test should also include tests from #1384 and #1685 (except test Multiple apps, one installed after BT connection, non SDL device is now invalid)

Core version / branch / commit hash / module tested against: Ford TDK
HMI name / version / branch / commit hash / module tested against: Ford TDK

Summary

This PR changes a limitation to the waking up the router service process where it would only start the SdlDeviceListener if there was a supplied BT device or if it was the only SDL app installed. This PR will allow the device lisetener to start any time as long as there is a BT device supplied from the broadcast receiver or if a BT device is connected using the headset or A2DP profiles. This is to increase the ability to to connect to IVIs without the need to always disconnect BT and reconnect.

Changelog

Enhancements
  • Update limitations for when to start the device listener.

CLA

@JulianKast JulianKast merged commit 1fb1482 into develop Dec 4, 2023
4 checks passed
@JulianKast JulianKast deleted the bugfix/issue_1878_device_listener_update branch December 4, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants