Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration validator with latest permissions and checks for exported #1875

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

joeygrover
Copy link
Member

Fixes #1874

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Unit Tests

N/A

Core Tests

N/A

Summary

This PR updates the IntegrationValidator to include some of the newly required permissions over the last couple of Android OS updates. It also added checks to ensure that the SdlRouterService is exported for the app along with the app's extension of the SdlBroadcastReceiver.

Changelog

Enhancements
  • Add checks for missing permissions
  • Add checks for exported flags being set to try for SDL components

CLA

@JulianKast JulianKast merged commit fb794d7 into develop Nov 29, 2023
4 checks passed
@JulianKast JulianKast deleted the bugfix/issue_1874_integration_validator branch November 29, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants