Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android, javaSE & javaEE gradle setup to read version for one file #1764

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented Nov 9, 2021

Fixes #1763

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE

Summary

This PR updates the gradle setup for android, javaSE & javaEE to read the version from one single file called VERSION instead of having 4 different files that needed to be updated separately.

Testing Steps

  1. Update the version in VERSION file to any unique version (like 5.3.0_xyz for example)
  2. Run ./gradlew build for javaSE
  3. Upload the JavaSE binary to maven central staging
  4. Confirm that the generated BuildConfig and uploaded library still use the old version that was set in gradle.properties
  5. Repeat the same steps for Android library

CLA

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1764 (b774684) into develop (0bda034) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1764      +/-   ##
=============================================
- Coverage      54.37%   54.37%   -0.01%     
  Complexity      5498     5498              
=============================================
  Files            562      562              
  Lines          25466    25466              
  Branches        3317     3317              
=============================================
- Hits           13847    13846       -1     
  Misses         10360    10360              
- Partials        1259     1260       +1     
Impacted Files Coverage Δ
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 50.00% <0.00%> (-1.22%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants