Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager will upload the same file multiple times #1736

Closed
JulianKast opened this issue Sep 22, 2021 · 0 comments
Closed

File Manager will upload the same file multiple times #1736

JulianKast opened this issue Sep 22, 2021 · 0 comments
Labels
bug A defect in the library manager-file Relating to the File Manager

Comments

@JulianKast
Copy link
Contributor

Bug Report

When trying to load multiple of the same artwork and the file is not uploaded yet, the file will be uploaded multiple times. This is because we create multiple of the same upload operation and they all execute.

We should probably implement the upload / delete operation to check if the file needs to be uploaded at the time it would run instead of the manager figuring out if the operation should be created at all.

Reproduction Steps
  1. Create 99 SDLArtworks that are exactly the same
  2. Attempt to upload all 99 in a loop
Expected Behavior

The one artwork should only be uploaded 1 time.

Observed Behavior

The one artwork will be uploaded 99 times, slowing down the head unit like crazy.

OS & Version Information
  • Android Version: n/a
  • SDL Android Version: 5.1.1
  • Testing Against: manticore
@jordynmackool jordynmackool added the bug A defect in the library label Sep 24, 2021
@jordynmackool jordynmackool added the manager-file Relating to the File Manager label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-file Relating to the File Manager
Projects
None yet
Development

No branches or pull requests

3 participants