Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choices not saved as preloaded if some choices fail #1715

Closed
RHenigan opened this issue Jul 7, 2021 · 1 comment
Closed

Choices not saved as preloaded if some choices fail #1715

RHenigan opened this issue Jul 7, 2021 · 1 comment
Labels
bug A defect in the library

Comments

@RHenigan
Copy link
Contributor

RHenigan commented Jul 7, 2021

Bug Report

The ChoiceSetManager currently only saves preloaded choices if all choices succeed in the PreloadChoicesOperation.
If any choices fail then the choices are not saved. We need to still save any successfully uploaded choices to avoid reuploading them in the future.
@RHenigan RHenigan mentioned this issue Jul 7, 2021
Merged
5 tasks
@jordynmackool jordynmackool added the bug A defect in the library label Jul 7, 2021
@JulianKast
Copy link
Contributor

Fixed with #1716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JulianKast @RHenigan @jordynmackool