Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnSdlChoiceChosen contains duplicate class definitions #14

Closed
mikeburke106 opened this issue Oct 10, 2014 · 0 comments
Closed

OnSdlChoiceChosen contains duplicate class definitions #14

mikeburke106 opened this issue Oct 10, 2014 · 0 comments
Assignees
Labels
best practice Not a defect but something that should be improved anyway

Comments

@mikeburke106
Copy link
Contributor

OnSdlChoiceChosen contains class definitions that are already defined elsewhere.

For example, the class has the following definition:

public class SdlSubMenu {
    private Integer _menuID = null;
    private Integer _position = null;
    private String _menuName = null;

    // Constructor
    SdlSubMenu(Integer menuID, Integer position, String menuName) {
        _menuID = menuID;
        _position = position;
        _menuName = menuName;
    }

    // Restrict no-arg constructor
    private SdlSubMenu() {}

        // Public Getters
    public Integer getMenuID() {
        return _menuID;
    }

    public String getMenuName() {
        return _menuName;
    }

    public String toString() {
        return _menuName;
    }
}

This class contains nearly the exact same methods and variables that are already defined as part of the AddSubMenu class.

These duplicate classes should be removed in favor of the existing classes.

@mikeburke106 mikeburke106 added proposal Accepted SDL Evolution Proposal enhancement and removed proposal Accepted SDL Evolution Proposal labels Oct 10, 2014
@mikeburke106 mikeburke106 added best practice Not a defect but something that should be improved anyway low priority labels Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Development

No branches or pull requests

4 participants