Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in SDLLifecycleManager #919

Closed
t-yoshii opened this issue Mar 30, 2018 · 0 comments
Closed

Memory leak in SDLLifecycleManager #919

t-yoshii opened this issue Mar 30, 2018 · 0 comments
Labels
bug A defect in the library
Milestone

Comments

@t-yoshii
Copy link

Bug Report

SDLFileManager doesn't call completion handler when it is shut down before transition to Ready state.
This causes that SDLLifecycleManager continues waiting dispatch_group. As a result, memory leaks occurs.

Reproduction Steps
  1. connect SDL Proxy to HU
  2. disconnect SDL Proxy during connection setup phase
  3. repeat 1 - 2
Expected Behavior

Memory leak does not occur

Observed Behavior

Memory leak occurs

OS & Version Information
  • iOS Version: all
  • SDL iOS Version: 5.1.1, 5.2.0
  • Testing Against: Our internal HU devboard
Test Case, Sample Code, and / or Example App

I will create PR later.

@joeljfischer joeljfischer added this to the 5.3.0 milestone Apr 4, 2018
@joeljfischer joeljfischer added the bug A defect in the library label Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

2 participants