Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioStreamingState should be notified to SDLManagerDelegate when SDLLifecycleManager becomes ready #863

Closed
t-yoshii opened this issue Feb 9, 2018 · 0 comments
Closed

AudioStreamingState should be notified to SDLManagerDelegate when SDLLifecycleManager becomes ready #863

t-yoshii opened this issue Feb 9, 2018 · 0 comments
Labels
bug A defect in the library
Milestone
5.2.0

Comments

@t-yoshii
Copy link

t-yoshii commented Feb 9, 2018

Bug Report

AudioStreamingState should be notified to SDLManagerDelegate when SDLLifecycleManager becomes ready.
Currently only HMI level is notified.

This behavior can cause "AUDIBLE" is not notified to SDLManagerDelegate forever if audio streaming state has become "AUDIBLE" before SDLLifecycleManager becomes ready. Because hmiStatusDidChange function in SDLLifecycleManager checks current lifecycle state (https://github.com/smartdevicelink/sdl_ios/blob/master/SmartDeviceLink/SDLLifecycleManager.m#L501).

Expected Behavior

SDL app can receive "AUDIBLE" state by SDLManagerDelegate when HU is connected.

Observed Behavior

SDL app sometimes can not receive "AUDIBLE" state by SDLManagerDelegate when HU is connected.

OS & Version Information
  • iOS Version: all
  • SDL iOS Version: 5.1.1
  • Testing Against: Our HU devboard
Test Case, Sample Code, and / or Example App

I will create PR later.
@t-yoshii t-yoshii mentioned this issue Feb 9, 2018
Merged
1 task
@joeljfischer joeljfischer added the bug A defect in the library label Feb 9, 2018
@joeljfischer joeljfischer added this to the 5.2.0 milestone Feb 9, 2018
@joeljfischer joeljfischer mentioned this issue Mar 16, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
2 participants
@joeljfischer @t-yoshii