You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the SDLUploadFileOperation class, if the file data exceeds the max size allowed for a packet, the file data is broken into chunks and sent in separate SDLPutFiles. However, there is a bug in the algorithm that breaks the file data into chunks because it assumes that the max allowed data chunk size is the max mtu size for the RPC service. This is wrong because the max mtu size is for the entire packet, which also includes the frame header, binary header, and JSON data along with the bulk data.
Since the file data is broken into chunks equal to the max mtu size, each of the messages generated for the SDLPutFiles will exceed the allowed mtu size. This means that in the protocol layer, the messages will be sent as multi-frame packets instead of as one single-frame packet. This defeats the purpose of breaking the file data into chunks and sending it in multiple SDLPutFiles.
Reproduction Steps
Use the file manager to upload a very large file that must be broken into separate SDLPutFiles.
Expected Behavior
All of the packets created for the SDLPutFiles generated by the SDLUploadFileOperation should be less than or equal to the mtu size allowed by the RPC service.
Observed Behavior
All of the packets (except the last packet) created for the SDLPutFiles generated by the SDLUploadFileOperation are greater than the mtu size allowed by the RPC service.
OS & Version Information
iOS Version: n/a
SDL iOS Version: 7.1
Testing Against: n/a
The text was updated successfully, but these errors were encountered:
In the
SDLUploadFileOperation
class, if the file data exceeds the max size allowed for a packet, the file data is broken into chunks and sent in separateSDLPutFile
s. However, there is a bug in the algorithm that breaks the file data into chunks because it assumes that the max allowed data chunk size is the maxmtu
size for the RPC service. This is wrong because the maxmtu
size is for the entire packet, which also includes the frame header, binary header, and JSON data along with the bulk data.Since the file data is broken into chunks equal to the max
mtu
size, each of the messages generated for theSDLPutFile
s will exceed the allowedmtu
size. This means that in the protocol layer, the messages will be sent as multi-frame packets instead of as one single-frame packet. This defeats the purpose of breaking the file data into chunks and sending it in multipleSDLPutFile
s.Reproduction Steps
SDLPutFile
s.Expected Behavior
All of the packets created for the
SDLPutFiles
generated by theSDLUploadFileOperation
should be less than or equal to themtu
size allowed by the RPC service.Observed Behavior
All of the packets (except the last packet) created for the
SDLPutFiles
generated by theSDLUploadFileOperation
are greater than themtu
size allowed by the RPC service.OS & Version Information
The text was updated successfully, but these errors were encountered: