Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC spec generator should not add #pragmas to suppress deprecation warnings to property and enum definitions #1757

Closed
NicoleYarroch opened this issue Aug 21, 2020 · 0 comments
Assignees
Labels
bug A defect in the library rpc-spec-generator Relating to the RPC spec generator

Comments

@NicoleYarroch
Copy link
Contributor

NicoleYarroch commented Aug 21, 2020

Bug Report

The RPC spec generator should not wrap deprecated properties or enum with #pragmas to suppress "-Wdeprecated-declarations as it is not necessary.

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// some property or enum definition
#pragma clang diagnostic pop
Reproduction Steps
  1. Run the generator script in the "generator" folder of the library.
Expected Behavior

The generated file for SDLCharacterSet should should generate for SDLCharacterSetType2:

/**
 * @deprecated
 * @since SDL 7.0.0
 */
extern SDLCharacterSet const SDLCharacterSetType2 __deprecated_msg("");
Observed Behavior

It currently generates:

/**
 * @deprecated
 * @since SDL 7.0.0
 */
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
extern SDLCharacterSet const SDLCharacterSetType2 __deprecated_msg("");
#pragma clang diagnostic pop
OS & Version Information
  • iOS Version: N/A
  • SDL iOS Version: 6.7
  • Testing Against: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library rpc-spec-generator Relating to the RPC spec generator
Projects
None yet
Development

No branches or pull requests

3 participants