RPC spec generator does not instantiate RPC responses correctly

[NicoleYarroch]

Bug Report

The RPC spec generator does not instantiate RPC responses correctly when generating convenience inits.

The generated convenience inits call super.init when they should call self.init. If self.init is not called, then the response is not created with its name (i.e. super.initWithName: is never called).

Reproduction Steps

1. Run the generator script in the "generator" folder of the library.

Expected Behavior

Generated convenience inits for RPC response should call self.init.

For example, in the SDLSubtleAlertResponse, this init should be created:

- (instancetype)initWithTryAgainTime:(nullable NSNumber<SDLUInt> *)tryAgainTime {
    self = [self init];
    if (!self) {
        return nil;
    }
    self.tryAgainTime = tryAgainTime;
    return self;
}

Observed Behavior

In the SDLSubtleAlertResponse, this init is created:

- (instancetype)initWithTryAgainTime:(nullable NSNumber<SDLUInt> *)tryAgainTime {
    self = [super init];
    if (!self) {
        return nil;
    }
    self.tryAgainTime = tryAgainTime;
    return self;
}

OS & Version Information

• iOS Version: n/a
• SDL iOS Version: 6.6
• Testing Against: n/a

[NicoleYarroch]

This is an issue in the generated inits for RPC requests as well.