Restarting the sdlManager crashes due to a race condition in the lifecycle manager

[NicoleYarroch]

Bug Report

When restarting the sdlManager, it crashes due to a race condition in the lifecycle manager.

Reproduction Steps

1. Connect the SDL app to sdl_core + sdl_hmi using a TCP connection. Launch the SDL app.
2. Open the menu and select "Exit UNAUTHORIZED_TRANSPORT_REGISTRATION". When the SDLManager's managerDidDisconnect delegate method is called, restart the sdlManager.

Expected Behavior

The SDL app restarts.

Observed Behavior

The SDL app crashes due to going from state Stopped to state Connected.

The SDLManager is started and the SDLLifecycleManager transitions to state started. However, before the transition can complete, the SDLRPCServiceDidConnect notification comes in. Since the lifecycle state is still stopped, the app crashes in the sdl_rpcServiceDidConnect method because it attempts to transition to state connected, which is an invalid state transition.

OS & Version Information

• iOS Version: n/a/
• SDL iOS Version: 6.6 (branch develop)
• Testing Against: sdl_core (tag 5.1.3) and sdl_hmi (branch develop).