Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SDLProxy to SDLLifecycleManager #1680

Closed
joeljfischer opened this issue Jun 8, 2020 · 0 comments
Closed

Refactor SDLProxy to SDLLifecycleManager #1680

joeljfischer opened this issue Jun 8, 2020 · 0 comments
Assignees
@joeljfischer
Labels
best practice Not a defect but something that should be improved anyway manager-lifecycle Relating to the manager layer - lifecycle manager

Comments

@joeljfischer
Copy link
Contributor

Bug Report

SDLProxy is now a private class that handles many intermediate duties between the lifecycle manager and the protocol layer. This can make updating these parts confusing. We should refactor it to have the lifecycle manager handle these duties - probably by composition and other objects. This will allow us to create classes that handle individual duties instead of the proxy class which handles many different things in one monolithic class.
@joeljfischer joeljfischer added best practice Not a defect but something that should be improved anyway manager-lifecycle Relating to the manager layer - lifecycle manager labels Jun 8, 2020
@joeljfischer joeljfischer self-assigned this Jun 8, 2020
@joeljfischer joeljfischer mentioned this issue Jun 16, 2020
Merged
29 tasks
@joeljfischer joeljfischer mentioned this issue Jul 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
best practice Not a defect but something that should be improved anyway manager-lifecycle Relating to the manager layer - lifecycle manager
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeljfischer