Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainThread checker warning at sdl_handleSystemRequestLaunchApp function #1662

Closed
t-yoshii opened this issue May 18, 2020 · 1 comment · Fixed by #1663
Closed

MainThread checker warning at sdl_handleSystemRequestLaunchApp function #1662

t-yoshii opened this issue May 18, 2020 · 1 comment · Fixed by #1663
Assignees
Labels
bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager

Comments

@t-yoshii
Copy link

Bug Report

sdl_handleSystemRequestLaunchApp function in SDLProxy.m calls [[UIApplication sharedApplication] openURL], this call can cause warning by Xcode main thread checker because it can be executed other than the main thread.

sdl_handleSystemRequestLaunchApp should be called only in the main thread.

Reproduction Steps
  1. Enable “Main Thread Checker” in Xcode, and run application in debug mode.
  2. Connect app to HU

  3. Make app foreground on HS
    
4. Run app on HU

  4. Run another app on HU

  5. Observe console log in HS
Expected Behavior

MainThread checker warning is NOT logged.

Observed Behavior

MainThread checker warning is logged.

OS & Version Information
  • iOS Version: 13.0
  • SDL iOS Version: 6.3.1
  • Testing Against: N/A
Test Case, Sample Code, and / or Example App

I will create PR

@joeljfischer joeljfischer added bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager labels May 18, 2020
@NicoleYarroch
Copy link
Contributor

Fixed in PR #1663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-lifecycle Relating to the manager layer - lifecycle manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants