Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC mutable array & dictionary properties and initialization variables should be immutable #152

Closed
joeljfischer opened this issue Mar 30, 2015 · 1 comment
Closed

RPC mutable array & dictionary properties and initialization variables should be immutable #152

joeljfischer opened this issue Mar 30, 2015 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway bug A defect in the library
Milestone
5.0.0

Comments

@joeljfischer
Copy link
Contributor

Only bad things can happen if consumers try to modify these properties. They should be immutable for clarity and safety.

An example is SDLAddCommand's vrCommands property.
@joeljfischer joeljfischer added bug A defect in the library best practice Not a defect but something that should be improved anyway labels Mar 30, 2015
@joeljfischer joeljfischer added this to the 5.0.0 milestone Mar 30, 2015
@joeljfischer joeljfischer changed the title SDLRPC mutable array properties should be immutable RPC mutable array & dictionary properties and initialization variables should be immutable Apr 24, 2015
@justinjdickow justinjdickow mentioned this issue Jul 31, 2015
Closed
@joeljfischer joeljfischer modified the milestones: 4.1.0, 5.0.0 Sep 30, 2015
@joeljfischer joeljfischer modified the milestones: 5.0.0, 4.X Jan 25, 2016
@joeljfischer
Copy link
Contributor Author

Fixed in #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway bug A defect in the library
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@joeljfischer