Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0267] Main Menu UI Updates #1510

Closed
theresalech opened this issue Dec 17, 2019 · 1 comment · Fixed by #1872
Closed

[SDL 0267] Main Menu UI Updates #1510

theresalech opened this issue Dec 17, 2019 · 1 comment · Fixed by #1872
Assignees
Labels
manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal rpc Relating to the RPC layer

Comments

@theresalech
Copy link
Contributor

Proposal: Main Menu UI Updates

This proposal is to update the main menu AddCommand and AddSubMenu RPCs to allow for the main menu to have the same UI capabilities as Choice in PerformInteraction popup menus.

Review: smartdevicelink/sdl_evolution#882

Steering Committee Decision:

The Steering Committee voted to accept this proposal with the following revision: additional text params should go to MenuParams.
The proposal .md file was updated to reflect these revisions on 12/17/19.

@theresalech theresalech added the proposal Accepted SDL Evolution Proposal label Dec 17, 2019
@joeljfischer joeljfischer added rpc Relating to the RPC layer manager-screen Relating to the manager layer - screen managers labels Jan 28, 2020
@jordynmackool
Copy link
Contributor

The proposal markdown file has been updated per the revisions included in the accepted Revise SDL 0267 Main Menu UI Updates.

Accepted Revisions:

Move parameters secondaryText and tertiaryText from the request body to the MenuParams struct.

Update the proposed HMI API Changes to the following:

HMI API Changes

Common.MenuParams
<struct name="MenuParams">
    <!-- New Parameters -->
    <param name="secondaryText" maxlength="500" type="String" mandatory="false">
        <description>Optional secondary text to display</description>
    </param>
    <param name="tertiaryText" maxlength="500" type="String" mandatory="false">
        <description>Optional tertiary text to display</description>
    </param>
</struct>
AddSubmenu
<function name="UI.AddSubMenu" messagetype="request">
    <!-- New Parameters -->
    <param name="secondaryImage" type="Image" mandatory="false">
        <description>Optional secondary image struct for menu cell</description>
    </param>
</function>
AddCommand
<function name="UI.AddCommand" messagetype="request">
    <!-- New Parameters -->
    <param name="secondaryImage" type="Image" mandatory="false">
        <description>Optional secondary image struct for menu cell</description>
    </param>
</function>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal rpc Relating to the RPC layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants